[EuiListGroup] and [Items] Adds gutterSize, color#2980
Merged
cchaos merged 7 commits intoelastic:masterfrom Mar 5, 2020
Merged
[EuiListGroup] and [Items] Adds gutterSize, color#2980cchaos merged 7 commits intoelastic:masterfrom
gutterSize, color#2980cchaos merged 7 commits intoelastic:masterfrom
Conversation
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_2980/ |
thompsongl
approved these changes
Mar 5, 2020
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_2980/ |
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_2980/ |
snide
approved these changes
Mar 5, 2020
Contributor
snide
left a comment
snide
left a comment
There was a problem hiding this comment.
Did a quick scan of this one for code and checked the preview.
andreadelrio
approved these changes
Mar 5, 2020
Contributor
andreadelrio
left a comment
andreadelrio
left a comment
There was a problem hiding this comment.
LGTM, just noticed a typo and added a question about classnames.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Support for new nav
EuiListGroupItem
colorCurrently, the only way to color the text of the list group items was by custom classes. Buttons were inheriting
textcolor, while links where inheritingprimarycolor. The default is still to inherit, but gives the consumer ways to forces the buttons, text or links to beprimary,textorsubdued.EuiListGroup
gutterSizeA static top margin was added to each item within the list group. Now there's an option to adjust that spacing to
none | s | m. Default iss. Andflushstill works appropriately.Tests & snippets
There was a major lacking in the tests for EuiListGroup, so those have been beefed up. And snippets have been added to all the doc examples.
Checklist
[ ] Checked for breaking changes and labeled appropriately[ ] Checked for accessibility including keyboard-only and screenreader modes